Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supported versions workflow: fix parsing and modify gem names #4294

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

quinna-h
Copy link
Contributor

@quinna-h quinna-h commented Jan 15, 2025

What does this PR do?

  • Update to only parse gemfile.lock files instead of also gemfile files
  • change the aws contrib to use the aws-sdk gem
  • change the http contrib to use net-http gem
  • change typos in httpx and makara: nil means we do not support the integration, infinity means we use latest

Motivation:

Addition to #4210

Change log entry

Additional Notes:

How to test the change?

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Jan 15, 2025
Copy link

github-actions bot commented Jan 15, 2025

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-01-15 22:37:10 UTC

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 15, 2025

Datadog Report

Branch report: add-gems-to-integrations
Commit report: 40fc101
Test service: dd-trace-rb

✅ 0 Failed, 22182 Passed, 1476 Skipped, 5m 12.36s Total Time

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.72%. Comparing base (9e3a3e3) to head (e458643).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
lib/datadog/tracing/contrib/aws/integration.rb 0.00% 1 Missing ⚠️
lib/datadog/tracing/contrib/http/integration.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4294   +/-   ##
=======================================
  Coverage   97.71%   97.72%           
=======================================
  Files        1356     1356           
  Lines       82489    82491    +2     
  Branches     4219     4219           
=======================================
+ Hits        80604    80612    +8     
+ Misses       1885     1879    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 15, 2025

Benchmarks

Benchmark execution time: 2025-01-15 23:01:37

Comparing candidate commit 40fc101 in PR branch add-gems-to-integrations with baseline commit 21106cd in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@quinna-h quinna-h changed the title supported versions workflow: small fixes and update gems supported versions workflow: fixes and update gems Jan 15, 2025
@quinna-h quinna-h changed the title supported versions workflow: fixes and update gems supported versions workflow: fix parsing and modify gem names Jan 15, 2025
@quinna-h quinna-h marked this pull request as ready for review January 15, 2025 22:37
@quinna-h quinna-h requested review from a team as code owners January 15, 2025 22:37
@marcotc marcotc enabled auto-merge (squash) January 15, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants